-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bold Text Rendering Issue #2183
Conversation
Thanks for the contribution! Before we can merge this, we need @suekou to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suekou Could you sign our CLA? Without it, we are unable to merge any external contributions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
=======================================
Coverage 82.07% 82.07%
=======================================
Files 18 18
Lines 1545 1545
Branches 443 443
=======================================
Hits 1268 1268
Misses 179 179
Partials 98 98 ☔ View full report in Codecov by Sentry. |
@seratch Thank you for reviewing this. As shown in the image, I have already signed the CLA on 2024-08-04. However, it appears that GitHub Actions is not recognizing it. I'm not fully familiar with the specifications of this CLA system. Is there anything that I need to do after signing the CLA? |
@suekou The email address you used for the commit could be different. Can you double-check if the address is the same with CLA signing? |
@seratch |
closed PR and re-opened so CLA check would re-run - looks like it's seeing the signed CLA now! |
@hello-ashleyintech Thank you very much for your help! |
Summary
This PR aims to fix the issue with Markdown bold formatting in the documentation, specifically where bold text was not rendered correctly after punctuation marks.
Before:
Requirements (place an
x
in each[ ]
)