-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(3.17.1): Publish v3.17.1 #2029
Conversation
…lack/oauth and @slack/socket-mode versions
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Rafael Fecha <r***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
Thanks for the contribution! Before we can merge this, we need @rafael-fecha to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I always forget about bolt when doing maintenance releases of the node SDKs 🤦
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2029 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 18 18
Lines 1531 1531
Branches 440 440
=======================================
Hits 1255 1255
Misses 178 178
Partials 98 98 ☔ View full report in Codecov by Sentry. |
@rafael-fecha it seems there was a backwards-incompatible update in chai 4.4 that affects node 12. Can you also change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe if we change the chai
dependency from:
"chai": "^4.2.0",
To:
"chai": "~4.3.0",
Then the tests for this PR will pass.
hey @filmaj thanks for the suggestion. i've just pushed the change |
@rafael-fecha please set the chai dependency to use the However, what we want is |
you are right, just pushed the latest change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working through this PR with me. As soon as the tests pass, I will merge and start the release process.
you are welcome ! thank you @filmaj for checking this so fast |
* chore(3.17.1): bump package json version and update @slack/web-api @slack/oauth and @slack/socket-mode versions to address axios security vulnerability * chore(chai): lock chai version in order to fix the ci test with lower node version
Summary
Fixes: #2028
Requirements (place an
x
in each[ ]
)