-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload code coverage reports using the Codecov GitHub Action #1937
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1937 +/- ##
=======================================
Coverage 82.18% 82.18%
=======================================
Files 18 18
Lines 1521 1521
Branches 436 436
=======================================
Hits 1250 1250
Misses 175 175
Partials 96 96 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've been meaning to do this for a while, and I think I'll follow what we end up settling on in this repo for the node-slack-sdk projects while I'm mucking around in there, but, one thing I noticed is, are we running the coverage report generation for each node version in the testing matrix? I believe we are (and I guess we did this all along!) but maybe we can run it on just one node version? Not sure if it makes a difference or not, but I'd probably default to only running the coverage report using the latest stable version of node we support.
@filmaj Totally right that we're uploading reports for each version! Honestly not sure what coverage was being reported with this, so nice catch. Updated this to only upload with the latest version as I agree this is a good call. Tests will still pass or fail on any version, and coverage should be similar between versions, but no more uploading coverage for each version! |
Summary
This PR replaces the
codecov
package, which has been deprecated, with the Codecov GitHub Action to hopefully report the uploaded coverage statuses.Requirements