Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtype matching #180

Merged
merged 1 commit into from
May 3, 2019
Merged

Conversation

shaydewael
Copy link
Contributor

Summary

The comparison was inverted

Requirements (place an x in each [ ])

@shaydewael shaydewael requested a review from aoberoi May 3, 2019 17:13
@codecov-io
Copy link

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files           7        7           
  Lines         440      440           
  Branches      120      120           
=======================================
  Hits          215      215           
  Misses        213      213           
  Partials       12       12
Impacted Files Coverage Δ
src/middleware/builtin.ts 22.01% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504e14e...07b6aa5. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented May 3, 2019

🤦‍♂

@shaydewael shaydewael merged commit 02d0d3b into slackapi:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants