Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Function -> SlackFunction #1536

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

srajiang
Copy link
Contributor

@srajiang srajiang commented Aug 3, 2022

Summary

This PR adds a few updates to improve naming in the function middleware implementation.

Updates:

  • Renames Function class to SlackFunction to reduce confusion as there's a reserved Function in JS.
  • Renames success and error utility arguments to completeSuccess and completeError for better consistency with verb syntax for listener arguments.
  • Small changes to Function types

Testing

  • Build this branch locally and npm link
  • hermes create -t slack-samples/bolt-ts-starter-template -b future
  • npm run build && hermes manifest to sanity check the manifest.hermes run -v to start the app
  • Test in your workspace that the function runs successfully.

This PR addresses much of the feedback in: #1383 with the exception of adding tests. Future PRs should add this coverage, then that PR should be ready to close out!

Requirements (place an x in each [ ])

@srajiang srajiang changed the title [Draft]: Update Function -> SlackFunction Update Function -> SlackFunction Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (future@b1de803). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             future    #1536   +/-   ##
=========================================
  Coverage          ?   79.76%           
=========================================
  Files             ?       20           
  Lines             ?     1626           
  Branches          ?      466           
=========================================
  Hits              ?     1297           
  Misses            ?      220           
  Partials          ?      109           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@srajiang srajiang self-assigned this Aug 3, 2022
@srajiang srajiang merged commit 7cd6a5e into future Aug 3, 2022
srajiang added a commit that referenced this pull request Aug 18, 2022
srajiang added a commit that referenced this pull request Aug 18, 2022
srajiang added a commit that referenced this pull request Aug 31, 2022
srajiang added a commit that referenced this pull request Aug 31, 2022
srajiang added a commit that referenced this pull request Sep 8, 2022
@srajiang srajiang deleted the future-update-function-util-args branch September 9, 2022 17:53
srajiang added a commit that referenced this pull request Sep 9, 2022
srajiang added a commit that referenced this pull request Sep 9, 2022
srajiang added a commit that referenced this pull request Sep 13, 2022
srajiang added a commit that referenced this pull request Sep 28, 2022
hello-ashleyintech pushed a commit that referenced this pull request Oct 14, 2022
srajiang added a commit that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants