-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Function -> SlackFunction #1536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srajiang
changed the title
[Draft]: Update Function -> SlackFunction
Update Function -> SlackFunction
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## future #1536 +/- ##
=========================================
Coverage ? 79.76%
=========================================
Files ? 20
Lines ? 1626
Branches ? 466
=========================================
Hits ? 1297
Misses ? 220
Partials ? 109 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8 tasks
seratch
approved these changes
Aug 3, 2022
srajiang
added a commit
that referenced
this pull request
Aug 18, 2022
srajiang
added a commit
that referenced
this pull request
Aug 18, 2022
srajiang
added a commit
that referenced
this pull request
Aug 31, 2022
srajiang
added a commit
that referenced
this pull request
Aug 31, 2022
srajiang
added a commit
that referenced
this pull request
Sep 8, 2022
srajiang
added a commit
that referenced
this pull request
Sep 9, 2022
srajiang
added a commit
that referenced
this pull request
Sep 9, 2022
srajiang
added a commit
that referenced
this pull request
Sep 13, 2022
srajiang
added a commit
that referenced
this pull request
Sep 28, 2022
hello-ashleyintech
pushed a commit
that referenced
this pull request
Oct 14, 2022
srajiang
added a commit
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a few updates to improve naming in the function middleware implementation.
Updates:
Function
class toSlackFunction
to reduce confusion as there's a reserved Function in JS.success
anderror
utility arguments tocompleteSuccess
andcompleteError
for better consistency with verb syntax for listener arguments.Testing
npm link
hermes create -t slack-samples/bolt-ts-starter-template -b future
npm run build && hermes manifest
to sanity check the manifest.hermes run -v
to start the appThis PR addresses much of the feedback in: #1383 with the exception of adding tests. Future PRs should add this coverage, then that PR should be ready to close out!
Requirements (place an
x
in each[ ]
)