Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1509 HTTPReceiver does not immediately respond to an invalid signature request (no response instead) #1528

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 25, 2022

Summary

This pull request resolves #1509

The cause is a regression bug in #1359, which has been affecting v3.11.0 through v3.12.0

Requirements (place an x in each [ ])

…alid signature request (no response instead)
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch labels Jul 25, 2022
@seratch seratch added this to the 3.12.1 milestone Jul 25, 2022
@seratch seratch requested a review from filmaj July 25, 2022 10:04
@seratch seratch self-assigned this Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1528 (25c816f) into main (898db4f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   82.07%   82.08%   +0.01%     
==========================================
  Files          18       18              
  Lines        1495     1496       +1     
  Branches      435      435              
==========================================
+ Hits         1227     1228       +1     
  Misses        172      172              
  Partials       96       96              
Impacted Files Coverage Δ
src/receivers/HTTPModuleFunctions.ts 80.00% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@seratch seratch merged commit af38327 into slackapi:main Jul 26, 2022
@seratch seratch deleted the issue-1509-http-receiver-bug branch July 26, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPReceiver does not immediately respond to an invalid signature request (no response instead)
2 participants