Adds JP translation for processBeforeResponse & AWS guide #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongjas
force-pushed
the
jwong-fix-1230-1246
branch
from
326a8e9 to
ee63b59
Compare
Codecov Report
@@ Coverage Diff @@
## main #1524 +/- ##
=======================================
Coverage 82.07% 82.07%
=======================================
Files 18 18
Lines 1495 1495
Branches 435 435
=======================================
Hits 1227 1227
Misses 172 172
Partials 96 96 |
seratch
requested changes
Jul 20, 2022
docs/_deployments/ja_aws-lambda.md
Outdated
| ``` | ||
|
|
||
| > 💡 [Serverless CLI をグローバルにインストールする](https://www.serverless.com/framework/docs/getting-started/)こともできます。その場合は`npm install -g serverless` というコマンドを実行します。 | ||
| Serverless でも [macOS、Windows、Linux](https://www.serverless.com/framework/docs/getting-started/) にインストールして利用できるコマンドラインインターフェイス（CLI）のツールが用意されています。インストールするには Serverless の[入門ガイド（英語）](https://www.serverless.com/framework/docs/getting-started/) をお読みください。 |
There was a problem hiding this comment.
You removed the first link to the getting started page. Can you make this part consistent?
Co-authored-by: Kazuhiro Sera <[email protected]>
Co-authored-by: Kazuhiro Sera <[email protected]>
seratch
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1230 and fixes #1246, the actual files changed can be found in:
#1229: https://github.com/slackapi/bolt-js/pull/1229/files
#1245: https://github.com/slackapi/bolt-js/pull/1245/files
Requirements (place an
xin each[ ])