-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add isEnterpriseInstall
to Context
#1511
Conversation
|
a5866ee
to
b81d900
Compare
I've just seen that events have access to |
b81d900
to
845ff64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Wow I had no idea of how complex the installation scenarios could be (i.e. individual workspace installs that exist inside an enterprise org). Thank you for this change 🙇
@rockingskier looks like some of the tests are failing, I believe because some unrelated tests are using empty mock objects for the |
845ff64
to
f2bd0d0
Compare
Thanks, @filmaj. That was embarrassingly obvious :D |
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 18 18
Lines 1495 1495
Branches 435 435
=======================================
Hits 1226 1226
Misses 172 172
Partials 97 97
Continue to review full report at Codecov.
|
Thank you very much @rockingskier ! Much appreciated 🙇 |
Summary
#1510 - Add
isEnterpriseInstall
to aid in processing events.Requirements (place an
x
in each[ ]
)