Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1478 ack() is not accessible in global middleware in TypeScript #1482

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 10, 2022

Summary

This pull request resolves #1478. The type of ack in app.use arguments had been AckFn | never. This pull request removes the pattern of never, so that the type is now AckFn | undefined.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jun 10, 2022
@seratch seratch added this to the 3.11.2 milestone Jun 10, 2022
@seratch seratch requested review from mwbrooks and filmaj June 10, 2022 01:25
@seratch seratch self-assigned this Jun 10, 2022
@seratch seratch requested a review from srajiang June 10, 2022 01:25
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1482 (7138b0b) into main (a48430e) will not change coverage.
The diff coverage is n/a.

❗ Current head 7138b0b differs from pull request most recent head 5f73338. Consider uploading reports for the commit 5f73338 to get more accurate results

@@           Coverage Diff           @@
##             main    #1482   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files          18       18           
  Lines        1494     1494           
  Branches      435      435           
=======================================
  Hits         1225     1225           
  Misses        172      172           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48430e...5f73338. Read the comment docs.

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @seratch! :)

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, big impact! 👍🏻

@seratch seratch merged commit 1a5e001 into slackapi:main Jun 10, 2022
@seratch seratch deleted the issue-1478-ack branch June 10, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ack() is not accessible in global middleware in TypeScript
4 participants