Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs for error patterns in AwsLambdaReceiver #1481

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 8, 2022

Summary

This pull request improves the debuggability of AwsLambdaReceiver apps. See #1480 (comment) for its context.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Jun 8, 2022
@seratch seratch added this to the 3.11.2 milestone Jun 8, 2022
@seratch seratch requested review from mwbrooks and srajiang June 8, 2022 23:04
@seratch seratch self-assigned this Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1481 (f25eb56) into main (80f78ea) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   81.97%   81.99%   +0.02%     
==========================================
  Files          18       18              
  Lines        1492     1494       +2     
  Branches      435      435              
==========================================
+ Hits         1223     1225       +2     
  Misses        172      172              
  Partials       97       97              
Impacted Files Coverage Δ
src/receivers/AwsLambdaReceiver.ts 71.42% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f78ea...f25eb56. Read the comment docs.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@srajiang srajiang merged commit a48430e into slackapi:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants