-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1472 say argument does not exist for pin_* events in TS #1473
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1473 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 18 18
Lines 1492 1492
Branches 435 435
=======================================
Hits 1223 1223
Misses 172 172
Partials 97 97 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
If it makes sense to fix it as a part of this ticket, the same problem exists for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍 on the unit tests. Thanks for taking care of this so quickly!
@wickerpopstar Thanks for reporting the same issue for reaction_added/reaction_removed events! I just sent one more PR for it: #1476 |
Summary
This pull request resolves #1472. The current pin_added / pin_removed event data types are not compatible with https://github.com/slackapi/bolt-js/blob/%40slack/bolt%403.11.1/src/types/events/index.ts#L81-L83
Requirements (place an
x
in each[ ]
)