Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply bunch of workaround for TypeScript 4.7 compiler compatibility #1466

Merged
merged 3 commits into from
May 27, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented May 27, 2022

Summary

This pull request resolves the issue mentioned at #1465 by a different approach. It seems that bolt-js's a bit complex type system was bitten by he behavior changes in TypeScript 4.7. This pull request uses any types to skip some of the type validations by TS compiler. These are unhappy workarounds so that we may want to remove these workarounds in future TS versions.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality TypeScript-specific labels May 27, 2022
@seratch seratch added this to the 3.11.2 milestone May 27, 2022
@seratch seratch requested review from filmaj, stevengill and srajiang May 27, 2022 00:52
@seratch seratch self-assigned this May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1466 (7d22007) into main (098f279) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
+ Coverage   81.82%   81.97%   +0.14%     
==========================================
  Files          18       18              
  Lines        1480     1492      +12     
  Branches      435      435              
==========================================
+ Hits         1211     1223      +12     
  Misses        172      172              
  Partials       97       97              
Impacted Files Coverage Δ
src/App.ts 83.87% <100.00%> (+0.22%) ⬆️
src/middleware/builtin.ts 84.55% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098f279...7d22007. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, what a mess... need to dedicate some time to re-working these types I think :(

@srajiang srajiang merged commit 23cc0e1 into slackapi:main May 27, 2022
@seratch seratch deleted the ts-4.7-compat branch May 27, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants