Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test coverage to the HTTPResponseAck class #1403

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Mar 29, 2022

Summary

Just trying to push the test coverage up.

@filmaj filmaj added the tests M-T: Testing work only label Mar 29, 2022
@filmaj filmaj requested a review from seratch March 29, 2022 21:02
@filmaj filmaj self-assigned this Mar 29, 2022
@filmaj filmaj force-pushed the httpresponseack-tests branch from f367d18 to 671cda5 Compare March 29, 2022 21:03
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1403 (671cda5) into main (a240aec) will increase coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
+ Coverage   78.58%   79.61%   +1.03%     
==========================================
  Files          17       17              
  Lines        1452     1452              
  Branches      428      428              
==========================================
+ Hits         1141     1156      +15     
+ Misses        211      199      -12     
+ Partials      100       97       -3     
Impacted Files Coverage Δ
src/receivers/HTTPResponseAck.ts 100.00% <0.00%> (+51.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a240aec...671cda5. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is so nice! The total coverage is almost 80% now!

@seratch seratch added this to the 3.11.0 milestone Mar 29, 2022
@seratch seratch merged commit 416dd43 into main Mar 29, 2022
@seratch seratch deleted the httpresponseack-tests branch March 29, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants