Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1397 bolt-js does not accept ssl_check requests properly #1400

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 29, 2022

Summary

This pull request resolves #1397

Requirements (place an x in each [ ])

@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Mar 29, 2022
@seratch seratch added this to the 3.11.0 milestone Mar 29, 2022
@seratch seratch requested review from mwbrooks and filmaj March 29, 2022 02:56
@seratch seratch self-assigned this Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1400 (9cc3b91) into main (e0613a6) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
+ Coverage   78.56%   78.58%   +0.01%     
==========================================
  Files          17       17              
  Lines        1446     1452       +6     
  Branches      426      428       +2     
==========================================
+ Hits         1136     1141       +5     
  Misses        211      211              
- Partials       99      100       +1     
Impacted Files Coverage Δ
src/receivers/HTTPModuleFunctions.ts 79.56% <83.33%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0613a6...9cc3b91. Read the comment docs.

@seratch seratch force-pushed the issue-1397-ssl-check branch from d4b2a9b to 9cc3b91 Compare March 29, 2022 03:29
@seratch seratch merged commit a240aec into slackapi:main Mar 29, 2022
@seratch seratch deleted the issue-1397-ssl-check branch March 29, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bolt-js does not accept ssl_check requests properly
3 participants