Fix #1335 Proper use of state parameter for the OAuth CSRF protection #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
Codecov Report
@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
- Coverage 77.13% 76.97% -0.17%
==========================================
Files 18 17 -1
Lines 1478 1446 -32
Branches 434 426 -8
==========================================
- Hits 1140 1113 -27
+ Misses 239 232 -7
- Partials 99 101 +2
Continue to review full report at Codecov.
|
10 tasks
filmaj
reviewed
Mar 28, 2022
| defaultRenderHtmlForInstallPath; | ||
| res.send(renderHtml(url)); | ||
| } | ||
| await installer.handleInstallPath(req, res, installPathOptions, installUrlOptions); |
mwbrooks
approved these changes
Mar 28, 2022
| @@ -60,6 +35,6 @@ receiver.router.get('/secret-page', (req, res) => { | |||
| }); | |||
|
|
|||
| (async () => { | |||
| await app.start(8080); | |||
| await app.start(3000); | |||
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1335 by migrating to the new
handleInstallPath()method, which is newly added in@slack/[email protected].Requirements (place an
xin each[ ])