-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy the App to Heroku with one click #1384
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1384 +/- ##
=======================================
Coverage 72.69% 72.69%
=======================================
Files 17 17
Lines 1465 1465
Branches 437 437
=======================================
Hits 1065 1065
Misses 310 310
Partials 90 90 Continue to review full report at Codecov.
|
Hi @MaurizioBella, thanks for submitting this PR! Utilizing Ideally, we would like to avoid having
@stevengill @filmaj @misscoded @mwbrooks @srajiang |
Co-authored-by: Kazuhiro Sera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @MaurizioBella!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice @MaurizioBella, thanks for the pull request!
@seratch I agree, it would be nice to not have app.json
in the repo's root directory but appears to be a requirement for Heroku.
Thanks for you all's reviews. I think that it's fine to merge this PR now. @MaurizioBella Thanks a lot for your contribution! |
Before merging this, I'm waiting for the CI builds complete |
|
Might be helpful to mention this new "one-click deployment to heroku" here: https://slack.dev/bolt-js/deployments/heroku |
Summary
Requirements (place an
x
in each[ ]
)