Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the App to Heroku with one click #1384

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Deploy the App to Heroku with one click #1384

merged 2 commits into from
Mar 24, 2022

Conversation

bemau
Copy link
Contributor

@bemau bemau commented Mar 23, 2022

Summary

  • Minor change allows users to deploy the app to Heroku with one click with the deploy template.

Requirements (place an x in each [ ])

@seratch seratch self-assigned this Mar 23, 2022
@seratch seratch added enhancement M-T: A feature request for new functionality docs M-T: Documentation work only labels Mar 23, 2022
@seratch seratch added this to the 3.11.0 milestone Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1384 (ab3c428) into main (7db76e5) will not change coverage.
The diff coverage is n/a.

❗ Current head ab3c428 differs from pull request most recent head 70b406c. Consider uploading reports for the commit 70b406c to get more accurate results

@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage   72.69%   72.69%           
=======================================
  Files          17       17           
  Lines        1465     1465           
  Branches      437      437           
=======================================
  Hits         1065     1065           
  Misses        310      310           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db76e5...70b406c. Read the comment docs.

@seratch
Copy link
Member

seratch commented Mar 23, 2022

Hi @MaurizioBella, thanks for submitting this PR! Utilizing heroku-buildpack-monorepo for deploying the sub directory template is so cool.

Ideally, we would like to avoid having app.json in this repository but it seems that having the file in the root directory is a requirement of "Deploy to Heroku" button.

The basic requirements for creating a button are that your app has a valid app.json file in its root directory, and that the app source code is hosted in a GitHub repository.
https://devcenter.heroku.com/articles/heroku-button#requirements

@stevengill @filmaj @misscoded @mwbrooks @srajiang
I myself am fine to merge this PR but I would like to know other maintainers' thoughts before merging it. For context, @srajiang suggested @MaurizioBella to send a pull request to this repo: slackapi/bolt-js-getting-started-app#11 (comment)

app.json Outdated Show resolved Hide resolved
Co-authored-by: Kazuhiro Sera <[email protected]>
@srajiang srajiang requested a review from mwbrooks March 23, 2022 20:14
@srajiang srajiang assigned misscoded and unassigned seratch and misscoded Mar 23, 2022
@srajiang srajiang requested review from misscoded and srajiang March 23, 2022 20:14
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @MaurizioBella!

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice @MaurizioBella, thanks for the pull request!

@seratch I agree, it would be nice to not have app.json in the repo's root directory but appears to be a requirement for Heroku.

@seratch
Copy link
Member

seratch commented Mar 23, 2022

Thanks for you all's reviews. I think that it's fine to merge this PR now. @MaurizioBella Thanks a lot for your contribution!

@seratch
Copy link
Member

seratch commented Mar 23, 2022

Before merging this, I'm waiting for the CI builds complete

@bemau
Copy link
Contributor Author

bemau commented Mar 23, 2022

Thanks for you all's reviews. I think that it's fine to merge this PR now. @MaurizioBella Thanks a lot for your contribution!
Absolutely, happy to contribute, and thanks, @srajiang, for pointing me to this repo. Great team-work!

@seratch seratch merged commit 8ab3105 into slackapi:main Mar 24, 2022
@orozcoadrian
Copy link

Might be helpful to mention this new "one-click deployment to heroku" here: https://slack.dev/bolt-js/deployments/heroku
Let me know if you'd like me to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants