-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote add to slack URL #1323
Quote add to slack URL #1323
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 72.88% 72.88%
=======================================
Files 17 17
Lines 1479 1479
Branches 442 442
=======================================
Hits 1078 1078
Misses 311 311
Partials 90 90
Continue to review full report at Codecov.
|
Hi @nicolls1 👋🏻 Thanks a lot for the pull request and congrats on your first-contribution to bolt-js! Before we can approve and merge your pull request, can you please sign the CLA (Contributor License Agreement)? 🙇🏻 |
Sorry, just had to double check it with my company but good to go now! |
Merging was blocked by being behind master and is now blocked by waiting for workflow. Feel free to merge or I can after workflow approval :) |
Summary
I needed to customize the install route and I noticed that the href URL isn't quoted.
Requirements (place an
x
in each[ ]
)