Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1320 plus add mising properties in events #1322

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 18, 2022

Summary

This pull request resolves #1320 plus adds missing properties in event data type definition.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality TypeScript-specific labels Feb 18, 2022
@seratch seratch added this to the 3.10.0 milestone Feb 18, 2022
@seratch seratch self-assigned this Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1322 (227ec5e) into main (e52252b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1322   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          17       17           
  Lines        1479     1479           
  Branches      442      442           
=======================================
  Hits         1078     1078           
  Misses        311      311           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52252b...227ec5e. Read the comment docs.

Comment on lines -796 to +893
updated: string;
updated: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@seratch seratch merged commit 7891454 into slackapi:main Feb 19, 2022
@seratch seratch deleted the issue-1320 branch February 19, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserChangeEvent.user.updated should be typed as a number
2 participants