Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SlackEvent type to include ChannelIDChangedEvent #1302

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

srajiang
Copy link
Contributor

@srajiang srajiang commented Feb 3, 2022

Summary

Fixes #1301 by updating SlackEvent to include ChannelIDChangedEvent.

Requirements (place an x in each [ ])

@srajiang srajiang added the enhancement M-T: A feature request for new functionality label Feb 3, 2022
@srajiang srajiang added this to the 3.10.0 milestone Feb 3, 2022
@srajiang srajiang self-assigned this Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1302 (b7239a7) into main (d1c7d15) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files          17       17           
  Lines        1439     1439           
  Branches      431      431           
=======================================
  Hits         1054     1054           
  Misses        300      300           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c7d15...b7239a7. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nicely done.

@@ -3,6 +3,7 @@ import { MessageEvent as AllMessageEvents } from './message-events';

/**
* All known event types in Slack's Events API
* Please refer to https://api.slack.com/events for more details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🙏

@srajiang srajiang merged commit 9782020 into slackapi:main Feb 3, 2022
@srajiang srajiang deleted the 1301-channel-id-changed branch February 3, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ChannelIDChangedEvent type to SlackEvent union type
2 participants