Add JP transln for userScopes property, add missing comma #1295

wongjas · 2022-01-27T08:45:36Z

Summary

Fixes #1289. Adds translation for userScopes property, adds in missing comma in the EN docs

Requirements (place an `x` in each `[ ]`)

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

…missing comma

codecov · 2022-01-27T08:47:26Z

Codecov Report

Merging #1295 (5c74c9f) into main (a09d885) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files          17       17           
  Lines        1439     1439           
  Branches      431      431           
=======================================
  Hits         1054     1054           
  Misses        300      300           
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a09d885...5c74c9f. Read the comment docs.

seratch · 2022-01-27T08:53:45Z

docs/_basic/authenticating_oauth.md

@@ -145,7 +145,7 @@ const app = new App({
      metadata: 'some session data',
      installPath: '/slack/installApp',
      redirectUriPath: '/slack/redirect',
-      userScopes: ['chat:write']
+      userScopes: ['chat:write'],


good catch!

Fixes slackapi#1289, Add JP translation for userScopes property, add …

5c74c9f

…missing comma

wongjas requested a review from seratch January 27, 2022 08:45

wongjas self-assigned this Jan 27, 2022

seratch added the docs M-T: Documentation work only label Jan 27, 2022

seratch added this to the 3.10.0 milestone Jan 27, 2022

seratch approved these changes Jan 27, 2022

View reviewed changes

seratch merged commit b6b7525 into slackapi:main Jan 27, 2022

wongjas deleted the jwong_fix_1289 branch January 27, 2022 23:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JP transln for userScopes property, add missing comma #1295

Add JP transln for userScopes property, add missing comma #1295

wongjas commented Jan 27, 2022

codecov bot commented Jan 27, 2022 •

edited

Loading

seratch Jan 27, 2022

Add JP transln for userScopes property, add missing comma #1295

Add JP transln for userScopes property, add missing comma #1295

Conversation

wongjas commented Jan 27, 2022

Summary

Requirements (place an x in each [ ])

codecov bot commented Jan 27, 2022 • edited Loading

Codecov Report

seratch Jan 27, 2022

Choose a reason for hiding this comment

Requirements (place an `x` in each `[ ]`)

codecov bot commented Jan 27, 2022 •

edited

Loading