Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade underlying oauth, types, web-api packages #1273

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 18, 2022

Summary

This pull request suggests to upgrade minor/patch versions of underlying Node SDKs. Especially, we should upgrade @slack/oauth to the latest as the latest version resolved a few critical bugs. Refer to https://github.com/slackapi/node-slack-sdk/releases/tag/%40slack%2Foauth%402.4.0 for more details.

If this looks good to you, please feel free to merge this PR and go ahead with the v3.9 release!

Requirements (place an x in each [ ])

@seratch seratch added this to the 3.9.0 milestone Jan 18, 2022
@seratch seratch requested review from filmaj and srajiang January 18, 2022 04:02
@seratch seratch self-assigned this Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1273 (0d6451f) into main (75d4ca2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          17       17           
  Lines        1438     1438           
  Branches      431      431           
=======================================
  Hits         1053     1053           
  Misses        300      300           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d4ca2...0d6451f. Read the comment docs.

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kaz!

@stevengill stevengill merged commit 2a97007 into slackapi:main Jan 18, 2022
@seratch seratch deleted the upgrade-underlying-sdks branch January 18, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants