Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1233 Removes redundant information, update link to actual view submissions #1234

Closed
wants to merge 2 commits into from
Closed

Fixes #1233 Removes redundant information, update link to actual view submissions #1234

wants to merge 2 commits into from

Conversation

wongjas
Copy link
Member

@wongjas wongjas commented Dec 6, 2021

Summary

Fixes #1233 Removes redundant information in the view submissions section. Update link to point to the correct location.

Requirements (place an x in each [ ])

@wongjas wongjas self-assigned this Dec 6, 2021
@wongjas wongjas requested review from srajiang and seratch December 6, 2021 11:24
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1234 (9d4fd93) into main (a1da64d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          17       17           
  Lines        1438     1438           
  Branches      431      431           
=======================================
  Hits         1053     1053           
  Misses        300      300           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1da64d...9d4fd93. Read the comment docs.

@seratch seratch added the docs M-T: Documentation work only label Dec 6, 2021
@seratch seratch added this to the 3.9.0 milestone Dec 6, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Japanese document page as well?

@wongjas
Copy link
Member Author

wongjas commented Dec 6, 2021

@seratch I've got this change on another branch as part of #1216!

@wongjas wongjas closed this Dec 7, 2021
@wongjas
Copy link
Member Author

wongjas commented Dec 7, 2021

Changes added to this PR instead: #1236

@wongjas wongjas deleted the jwong_fix_view_submission branch December 8, 2021 01:13
@filmaj filmaj removed this from the 3.9.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section on view submissions has redundant information and the link should be updated
3 participants