-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expires at in updateConversation context #1221
Conversation
Hi @shubhamjajoo, thanks for taking the time to submit this PR! The change looks good me but can you add some tests to https://github.com/slackapi/bolt-js/blob/main/src/conversation-store.spec.ts for verifying the behavior changes? |
Hi, @seratch , Added the test for the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1221 +/- ##
==========================================
+ Coverage 73.20% 73.22% +0.01%
==========================================
Files 17 17
Lines 1437 1438 +1
Branches 431 431
==========================================
+ Hits 1052 1053 +1
Misses 300 300
Partials 85 85
Continue to review full report at Codecov.
|
Summary
Fix issue : Context method updateConversation should accept expiration time
#190
Requirements (place an
x
in each[ ]
)