-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions job for better triage process #1213
Conversation
4dc5a92
to
935f21e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
=======================================
Coverage 73.20% 73.20%
=======================================
Files 17 17
Lines 1437 1437
Branches 431 431
=======================================
Hits 1052 1052
Misses 300 300
Partials 85 85 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I left a few comments.
.github/workflows/triage-issues.yml
Outdated
days-before-issue-close: 10 | ||
days-before-pr-stale: -1 | ||
days-before-pr-close: -1 | ||
stale-issue-label: stale-no-activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use the term "auto-triage", consistently having the term in the labels may be easier to understand. Like this:
- stale-issue-label: auto-triage-stale
- exempt-issue-labels: auto-triage-skip
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that - I will add those updates.
- uses: actions/[email protected] | ||
with: | ||
days-before-issue-stale: 30 | ||
days-before-issue-close: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 days sounds reasonable 👍
.github/workflows/triage-issues.yml
Outdated
days-before-pr-close: -1 | ||
stale-issue-label: stale-no-activity | ||
stale-issue-message: 👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. | ||
close-issue-message: This issue has been closed due to being inactive for 10 days with no further update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
being inactive for 10 days with no further update.
In this situation, the issue should be inactive for 40+ days (30 days before being marked as stale, and then 10 days until closing), right?
Also, (perhaps, other maintainers can come up with a better sentence but) using a bit more friendly message like "As this issue has been inactive for more than one month, let us close this. Thanks again for writing in here!" or so may be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
"As this issue has been inactive for more than one month, we will be closing it. Thanks again for writing in!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echoing @seratch's comments, but LGTM in general!
935f21e
to
7746a8f
Compare
exempt-all-milestones: true | ||
remove-stale-when-updated: true | ||
enable-statistics: true | ||
debug-only: true # TODO: remove after test run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srajiang when to remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very shortly - I'm reviewing the output of the test run now. If all clear on that and it's doing what I think it should be doing, we can remove it. I won't include this line for PRs in other repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output is here: https://github.com/slackapi/bolt-js/runs/4257717061?check_suite_focus=true in case you'd like to review the triage results (when performed in debug mode).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Nice work.
days-before-pr-close: -1 | ||
stale-issue-label: auto-triage-stale | ||
stale-issue-message: 👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. | ||
close-issue-message: As this issue has been inactive for more than one month, we will be closing it. Thanks again for writing in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a CTA that the issue can be re-opened if anyone wants? I'm cool either way.
Summary
This PR adds an action which will automate stale-ing and closing inactive issues. This action does not impact:
3.x.
auto-triage-skip
.For inactive issues:
auto-triage-stale
label and post a message in thread notifying all participants that after 10 further days w/out activity, the issue will be closed.For maintainers, and for the wider community:
👋 The goal with these changes is to make sure that issues are staying updated, as activity is the best indicator that it will be resolved! That means, if
more info
is needed and you need a bit more time to investigate, or if we need more time to investigate an issue internally, the best way to keep the issue updated is to post a comment!Todo:
debug-only
: falseRequirements (place an
x
in each[ ]
)