Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logging example so that it is valid JS, now also in Japanese #1174

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 20, 2021

No description provided.

@filmaj filmaj added the docs M-T: Documentation work only label Oct 20, 2021
@filmaj filmaj requested a review from seratch October 20, 2021 21:31
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1174 (b055ee5) into main (fc2c737) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files          15       15           
  Lines        1360     1360           
  Branches      405      405           
=======================================
  Hits          977      977           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2c737...b055ee5. Read the comment docs.

@seratch seratch added this to the 3.8.0 milestone Oct 20, 2021
@seratch seratch merged commit 507b8c7 into main Oct 20, 2021
@seratch seratch deleted the fix-logging-example-ja branch October 20, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants