-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1068 Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor #1077
Fix #1068 Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor #1077
Conversation
…iver: Receiver arguments in App constructor
Codecov Report
@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 68.73% 68.87% +0.13%
==========================================
Files 13 13
Lines 1206 1208 +2
Branches 355 356 +1
==========================================
+ Hits 829 832 +3
Misses 304 304
+ Partials 73 72 -1
Continue to review full report at Codecov.
|
I think this one is ready for merge but just in case, I'll wait for others' comments until tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Summary
This pull request fixes #1068 . I'm feeling that the error message can be improved. Suggestions would be appreciated!
Requirements (place an
x
in each[ ]
)