ESLint Config Migration: Use tsconfig's resolveJsonModule, replace require with import #1053
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,20 +18,22 @@ | |
| "main": "./dist/index.js", | ||
| "types": "./dist/index.d.ts", | ||
| "files": [ | ||
| "dist/**/*.map", | ||
| "dist/**/*.js", | ||
| "dist/**/*.d.ts" | ||
| ], | ||
| "engines": { | ||
| "node": ">=12.13.0", | ||
| "npm": ">=6.12.0" | ||
| }, | ||
| "scripts": { | ||
| "prepare": "npm run build", | ||
| "build": "npm run build:clean && tsc --build src", | ||
|
There was a problem hiding this comment. More information on |
||
| "build:clean": "shx rm -rf ./dist ./coverage ./.nyc_output", | ||
| "lint": "eslint --ext .ts src", | ||
| "mocha": "TS_NODE_PROJECT=src/tsconfig.json nyc mocha --config .mocharc.json \"src/**/*.spec.ts\"", | ||
| "test": "npm run lint && npm run mocha && npm run test:types", | ||
| "test:types": "tsd types-tests", | ||
| "coverage": "codecov", | ||
| "watch": "npx nodemon --watch 'src' --ext 'ts' --exec npm run build" | ||
| }, | ||
|
|
@@ -81,8 +83,5 @@ | |
| "ts-node": "^8.1.0", | ||
| "tsd": "^0.13.1", | ||
| "typescript": "^4.1.0" | ||
|
There was a problem hiding this comment. I removed this section in favour of explicitly specifying the directory to run |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| { | ||
| "compilerOptions": { | ||
| /* Basic Options */ | ||
| "target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "resolveJsonModule": true, | ||
| // "lib": [], /* Specify library files to be included in the compilation. */ | ||
| // "allowJs": true, /* Allow javascript files to be compiled. */ | ||
| // "checkJs": true, /* Report errors in .js files. */ | ||
| // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ | ||
| "sourceMap": true, /* Generates corresponding '.map' file. */ | ||
| // "outFile": "./", /* Concatenate and emit output to single file. */ | ||
| "outDir": "../dist", /* Redirect output structure to the directory. */ | ||
| "rootDir": ".", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ | ||
| "composite": true, /* Enable project compilation */ | ||
| // "removeComments": true, /* Do not emit comments to output. */ | ||
| // "noEmit": true, /* Do not emit outputs. */ | ||
| // "importHelpers": true, /* Import emit helpers from 'tslib'. */ | ||
| // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ | ||
| // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ | ||
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| // "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ | ||
| // "strictNullChecks": true, /* Enable strict null checks. */ | ||
| // "strictFunctionTypes": true, /* Enable strict checking of function types. */ | ||
| // "strictBindCallApply": true, /* Enable strict 'bind', 'call', and 'apply' methods on functions. */ | ||
| // "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */ | ||
| // "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
|
|
||
| /* Additional Checks */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
|
|
||
| /* Module Resolution Options */ | ||
| "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | ||
| "baseUrl": ".", /* Base directory to resolve non-absolute module names. */ | ||
| "paths": { /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ | ||
| "*": ["../types/*"] | ||
| }, | ||
| // "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */ | ||
| // "typeRoots": [], /* List of folders to include type definitions from. */ | ||
| // "types": [], /* Type declaration files to be included in compilation. */ | ||
| // "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ | ||
| "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ | ||
| // "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */ | ||
|
|
||
| /* Source Map Options */ | ||
| // "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */ | ||
| // "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */ | ||
| // "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ | ||
| // "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */ | ||
|
|
||
| /* Experimental Options */ | ||
| // "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */ | ||
| // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ | ||
| }, | ||
| "references": [ | ||
| { "path": "../" }, | ||
| ], | ||
| "include": [ | ||
| "**/*", | ||
| ], | ||
| "exclude": [ | ||
| "**/*.spec.ts", | ||
| "test-helpers.ts", | ||
| "**/tsconfig.tsbuildinfo", | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "types": "dummy.d.ts", | ||
| "tsd": { | ||
| "directory": "../src" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "compilerOptions": { | ||
| /* Basic Options */ | ||
| "target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "resolveJsonModule": true, | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ | ||
| "sourceMap": true, /* Generates corresponding '.map' file. */ | ||
| "outDir": "../dist", /* Redirect output structure to the directory. */ | ||
| "rootDir": "..", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ | ||
| /* Strict Type-Checking Options */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
|
|
||
| /* Additional Checks */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
|
|
||
| /* Module Resolution Options */ | ||
| "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | ||
| "baseUrl": ".", /* Base directory to resolve non-absolute module names. */ | ||
| "paths": { /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ | ||
| "*": ["../types/*"] | ||
| }, | ||
| "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ | ||
| }, | ||
| "include": [ | ||
| "**/*", | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is to avoid including
tsconfig.tsbuildinfo, which is a new "cache" filetscuses when you use Project References and thetsc --buildcommand.