Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AwsLambdaReceiver fails to parse event.body if isBase64Encoded is true #971

Closed
4 of 10 tasks
seratch opened this issue Jun 19, 2021 · 0 comments · Fixed by #972
Closed
4 of 10 tasks

AwsLambdaReceiver fails to parse event.body if isBase64Encoded is true #971

seratch opened this issue Jun 19, 2021 · 0 comments · Fixed by #972
Assignees
@seratch
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor
Milestone
3.4.1

Comments

@seratch
Copy link
Member

seratch commented Jun 19, 2021

Description

AwsLambdaReceiver fails to parse event.body if isBase64Encoded is true (this depends on your configuration on the AWS side). We should have extra logic to check if the body is base64 encoded here: https://github.com/slackapi/bolt-js/blob/%40slack/bolt%403.4.0/src/receivers/AwsLambdaReceiver.ts#L110

Describe your issue here.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor labels Jun 19, 2021
@seratch seratch added this to the 3.5.0 milestone Jun 19, 2021
@seratch seratch self-assigned this Jun 19, 2021
Merged
2 tasks
seratch pushed a commit that referenced this issue Jun 29, 2021
@TheManWhoStaresAtCode
Fix #971 AwsLambdaReceiver fails to parse event.body if isBase64Encod…
6ce89ae 
…ed is true (#972)

* decode event body in case it is base64 encoded

* revert autoformatting to import statements

* fix linting issues
@stevengill stevengill modified the milestones: 3.5.0, 3.4.1 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor
Projects
None yet
Milestone
3.4.1
2 participants
@seratch @stevengill