Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bot_id / bot_profile to GenericMessageEvent #956

Closed
4 of 10 tasks
seratch opened this issue Jun 3, 2021 · 0 comments · Fixed by #957
Closed
4 of 10 tasks

Add bot_id / bot_profile to GenericMessageEvent #956

seratch opened this issue Jun 3, 2021 · 0 comments · Fixed by #957
Assignees
@seratch
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Milestone
3.4.0

Comments

@seratch
Copy link
Member

seratch commented Jun 3, 2021

Description

As pointed out at #955 , the message even types do not have some properties like bot_profile. Before releasing v3.4.0, we should check the message event interface and add the missing ones.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific labels Jun 3, 2021
@seratch seratch added this to the 3.4.0 milestone Jun 3, 2021
@seratch seratch self-assigned this Jun 3, 2021
@seratch seratch changed the title Add all missing properties in message-type event payloads Add bot_id / bot_profile to GenericMessageEvent Jun 4, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Jun 4, 2021
@seratch
Fix slackapi#956 Add bot_id / bot_profile to GenericMessageEvent
2c5c812
@seratch seratch mentioned this issue Jun 4, 2021
Merged
2 tasks
seratch added a commit that referenced this issue Jun 4, 2021
@seratch
Fix #956 Add bot_id / bot_profile to GenericMessageEvent (#957)
d142ab1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Fix #956 Add bot_id / bot_profile to GenericMessageEvent seratch/bolt-js
1 participant
@seratch