Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests for SocketModeReceiver #750

Closed
4 of 10 tasks
stevengill opened this issue Jan 13, 2021 · 1 comment · Fixed by #1012
Closed
4 of 10 tasks

Add Tests for SocketModeReceiver #750

stevengill opened this issue Jan 13, 2021 · 1 comment · Fixed by #1012
Assignees
@filmaj
Labels
tests M-T: Testing work only
Milestone
3.6.0

Comments

@stevengill
Copy link
Member

Description

Need to write some tests for SocketModeReceiver after figuring out an appropriate test harness.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version:

node version:

OS version(s):

Steps to reproduce:

Expected result:

What you expected to happen

Actual result:

What actually happened

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.
@stevengill stevengill added the tests M-T: Testing work only label Jan 13, 2021
@seratch seratch self-assigned this Mar 5, 2021
@seratch
Copy link
Member

seratch commented Mar 18, 2021

Probably, I will start working on this soon. If anyone in the community has thoughts or ideas about this, sharing them with us would be greatly appreciated!

@seratch seratch modified the milestones: 3.4.0, 3.5.0 Mar 23, 2021
@seratch seratch mentioned this issue Apr 9, 2021
Closed
9 tasks
@seratch seratch modified the milestones: 3.5.0, 3.6.0 Jul 2, 2021
@seratch seratch removed their assignment Jul 2, 2021
filmaj pushed a commit to filmaj/bolt-js that referenced this issue Jul 20, 2021
Add basic test for SocketModeReceiver constructor (slackapi#750)
9a281d0
@filmaj filmaj mentioned this issue Jul 20, 2021
Merged
2 tasks
filmaj pushed a commit to filmaj/bolt-js that referenced this issue Jul 20, 2021
Add basic test for SocketModeReceiver constructor (slackapi#750)
177b66d
@filmaj filmaj self-assigned this Jul 20, 2021
@stevengill stevengill linked a pull request Jul 20, 2021 that will close this issue
Add tests for SocketModeReceiver (#750) #1012
Merged
2 tasks
filmaj pushed a commit to filmaj/bolt-js that referenced this issue Jul 21, 2021
Add basic tests for SocketModeReceiver constructor, start and stop me…
282637f 
…thods. (slackapi#750)
seratch pushed a commit that referenced this issue Jul 21, 2021
@filmaj
Add basic tests for SocketModeReceiver constructor, start and stop me…
03355fb 
…thods. (#750) (#1012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filmaj filmaj

Labels
tests M-T: Testing work only
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Add tests for SocketModeReceiver (#750) filmaj/bolt-js
3 participants
@seratch @filmaj @stevengill