Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-workspace app's Events API compatibility in shared channels #687

Closed
4 of 10 tasks
seratch opened this issue Nov 24, 2020 · 0 comments
Closed
4 of 10 tasks

Multi-workspace app's Events API compatibility in shared channels #687

seratch opened this issue Nov 24, 2020 · 0 comments
Assignees
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Milestone

Comments

@seratch
Copy link
Member

seratch commented Nov 24, 2020

Description

Currently, Bolt extracts enterprise_id and team_id from the top-level fields in the Events API payload. It works for single workspace apps but it doesn't for multi-workspace apps (OAuth flow supported apps). The fields are supposed to be the ones for source workspace (the originator of the shared channel) in shared channels. Bolt needs to respect authorizations[0].team_id over team_id (the same for enterprise_id).

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version: ~ v2.4.1
node version: any
OS version(s): any

  1. Install an OAuth flow supported app into workspace A
  2. Add the bot user to a shared channel created by Workspace B
  3. Handle message events in the shared channel
  4. context.team_id is not A but B in this case

Expected result:

Bolt always tells the workspace A for incoming requests

Actual result:

Bolt fails the authorized workspace ID.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch labels Nov 24, 2020
@seratch seratch added this to the v2.4 milestone Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Development

No branches or pull requests

2 participants