Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axios to latest 0.26.1 #1364

Closed
6 tasks
msrivastav13 opened this issue Mar 11, 2022 · 1 comment · Fixed by #1366
Closed
6 tasks

Update axios to latest 0.26.1 #1364

msrivastav13 opened this issue Mar 11, 2022 · 1 comment · Fixed by #1366
Assignees
Labels
Milestone

Comments

@msrivastav13
Copy link

msrivastav13 commented Mar 11, 2022

Description

axios is being used today in bolt-js for @slack/web-api and @slack/bolt packages. There is a vulnerability detected documented at GHSA-pw2r-vq6v-hr8c. This is due to a package follow-redirects.

This is a medium vulnerability and hence please update the axios dependency to at-least 0.26.0 that solves this. Check the release tag here

What type of issue is this? (place an x in one of the [ ])

  • [x ] bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • [ x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [ x] I've read and agree to the Code of Conduct.
  • [ x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

This is a security issue of type moderate risk. More details about the risk here.

Reproducible in:

package version:

node version:

OS version(s):

Steps to reproduce:

Expected result:

What you expected to happen

Actual result:

What actually happened

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

seratch added a commit to seratch/bolt-js that referenced this issue Mar 11, 2022
@seratch seratch added this to the 3.11.0 milestone Mar 11, 2022
@seratch seratch self-assigned this Mar 11, 2022
@seratch
Copy link
Member

seratch commented Mar 11, 2022

Hi @msrivastav13, thanks for reporting this issue! I just submitted a pull request fixing this: #1366 The next release will rely on only 0.26.1 or newer version of axios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants