Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example code for subtype() middleware docs #1237

Closed
4 of 10 tasks
srajiang opened this issue Dec 7, 2021 · 0 comments · Fixed by #1240
Closed
4 of 10 tasks

Update example code for subtype() middleware docs #1237

srajiang opened this issue Dec 7, 2021 · 0 comments · Fixed by #1240
Assignees
Labels
docs M-T: Documentation work only
Milestone

Comments

@srajiang
Copy link
Member

srajiang commented Dec 7, 2021

Description

The Filtering on message subtypes mention to use the subtype() middleware but doesn't explicitly call out that you need to import it from Bolt so you run into a subtype is not defined reference error.

We can have import in the code example use: https://api.slack.com/events/message/message_changed

Also the example currently uses bot_message but these don't currently show uyp with Granular Bot messages as per a outstanding bug.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@srajiang srajiang added the docs M-T: Documentation work only label Dec 7, 2021
@srajiang srajiang added this to the 3.9.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants