Redundant code path inside an if/else block in App class

[TEMHITHORPHE]

Description

Describe your issue here.

What type of issue is this? (place an x in one of the [ ])

• bug
• enhancement (feature request)
• question
• documentation related
• example code related
• testing related
• discussion

Requirements (place an x in each of the [ ])

• I've read and understood the Contributing guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.
• I've searched for any related issues and avoided creating a duplicate issue.

---

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version:@slack/[email protected]

node version:14.17.5

OS version(s):Win32

Steps to reproduce:

1. Just open the source code file and see. ( … /node_modules/@slack/bolt/dist/App.js:404)

Expected result:

Take a different code path, i.e. call a different function if ELSE block executed

Actual result:

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

[seratch]

@TEMHITHORPHE Thanks for taking the time to report this!

The TypeScript code has a slight difference but it does not make any runtime benefit: https://github.com/slackapi/bolt-js/blob/%40slack/bolt%403.8.1/src/App.ts#L784-L790

Indeed, the lines of code are just redundant. We can simplify the code in future versions.

[TEMHITHORPHE]

@seratch

Okay, but I sure hope "redundant" is only what it is, cause I had to dig into source when I was getting a funny "slack_bot_authorization_error" on a recent(and first) AWS Lambda deployment days ago, brought the entire project to a standstill, and am currently just starting again from scratch, following the steps from https://slack.dev/bolt-js/deployments/aws-lambda like a baby, in case I missed any steps during my previous deployment. Needless to say that too just hit a snag, because for whatever reason I don't understand, "serverless-offline" is not responding to SLACK 's Event API's challenge, but that's an "issue" for another day.