Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #2242 by upgrading express and its dependencies to newer major ve…
Browse files Browse the repository at this point in the history
…rsions
seratch authored and Filip Maj committed Oct 17, 2024
1 parent 1ebd657 commit 7e8cb8d
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@
"@types/promise.allsettled": "^1.0.3",
"@types/tsscmp": "^1.0.0",
"axios": "^1.7.4",
"express": "^4.21.0",
"express": "^5.0.0",
"path-to-regexp": "^8.1.0",
"promise.allsettled": "^1.0.2",
"raw-body": "^2.3.3",
4 changes: 2 additions & 2 deletions src/receivers/ExpressReceiver.spec.ts
Original file line number Diff line number Diff line change
@@ -529,7 +529,7 @@ describe('ExpressReceiver', function () {
// Act
const req = { body: { }, url: 'http://localhost/slack/oauth_redirect', method: 'GET' } as Request;
const resp = { send: () => { } } as Response;
(receiver.router as any).handle(req, resp);
(receiver.router as any).handle(req, resp, () => {});

// Assert
assert(handleStub.calledWith(req, resp, callbackOptions), 'installer.handleCallback not called');
@@ -552,7 +552,7 @@ describe('ExpressReceiver', function () {
// Act
const req = { body: { }, url: 'http://localhost/slack/oauth_redirect', method: 'GET' } as Request;
const resp = { send: () => { } } as Response;
(receiver.router as any).handle(req, resp);
(receiver.router as any).handle(req, resp, () => {});

// Assert
assert(handleStub.calledWith(req, resp, callbackOptions, sinon.match({ scopes })), 'installer.handleCallback not called');

0 comments on commit 7e8cb8d

Please sign in to comment.