Support newer rails and test against it #164
Conversation
Generated by 🚫 Danger |
| exclude: | ||
| - ruby: '2.6.2' | ||
| active_record: '~> 7.0.0' | ||
| name: test (ruby=${{ matrix.ruby }}, postgresql=${{ matrix.postgresql }}, active_record=${{ matrix.active_record }}) |
There was a problem hiding this comment.
I'd prefer it if we kept the original entry matrix format to be consistent with other .yml, and not use exclude because this is 2 x 2 x 3 and will grow out of control fast every time we add a new ruby version or a new AR version or a new PGsql version. The list of excludes becomes hard to manage. Add the active_record values that should have been there in the first place?
| @@ -84,7 +84,7 @@ class TeamsEndpoint < Grape::API | |||
| if team | |||
| team.ping_if_active! | |||
|
|
|||
| team.update_attributes!( | |||
| team.update!( | |||
There was a problem hiding this comment.
This is the only substantive change of this PR. update_attribute! has been an alias to update! since rails 4.0 and was finally deprecated in rails 6.1 and dropped in rails 7.0
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| ### 2.0.2 (Next) | |||
|
|
|||
| * [#163](https://github.com/slack-ruby/slack-ruby-bot-server/pull/163): Updated releasing documentation - [@crazyoptimist](https://github.com/crazyoptimist). | |||
| * [#164](https://github.com/slack-ruby/slack-ruby-bot-server/pull/164): Support newer rails and test against it - [@maths22](https://github.com/maths22). | |||
There was a problem hiding this comment.
Let's write which version of Rails, e.g. "Add support for Rails 7", it won't be "newer" forever.
| @@ -84,7 +84,7 @@ class TeamsEndpoint < Grape::API | |||
| if team | |||
| team.ping_if_active! | |||
|
|
|||
| team.update_attributes!( | |||
| team.update!( | |||
|
Thanks, merging this. Will do a release soon. There might be other libraries that need similar updates, https://github.com/slack-ruby/slack-ruby-bot-server-events or https://github.com/slack-ruby/slack-ruby-bot-server-rtm, appreciate any help you can give! |
|
I use |
No description provided.