-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cursor_pagination with pagy_cursor #158
Replace cursor_pagination with pagy_cursor #158
Conversation
d32b98a
to
8ea45ad
Compare
@dblock this is ready for review. |
Nice! Since this is a breaking change, let's make the version 2.0 in this PR (CHANGELOG and version.rb please). |
because it's a conditional dependency
Generated by 🚫 Danger |
Done. Seems like tests fail due to the rate limit, which is fine. |
Merged, thanks! |
Looks like https://github.com/slack-ruby/slack-ruby-bot-server/actions/runs/3856495932/jobs/6572763647 failed, care to take a look? |
Could you manually run the failed workflows again? I guess it's github. |
This might be related. Probably smaller runner image is assigned or something else during the workflow run. 9 of 10, not an issue in the code. |
Complains about an API rate limit? https://github.com/slack-ruby/slack-ruby-bot-server/actions/runs/3856495932/jobs/6588027991 |
Yes, it's github. So running the workflow again manually will just be fine, like when GHA servers get less load. |
Looks like this is angular/webdriver-manager#216. We need to have reliable CI, looking at this. |
@crazyoptimist Care to add a section to UPGRADING.md? I believe at the very least users will need to swap gems in their Gemfile. |
|
Close #148 #126
cursor_pagination is abandoned and no longer maintained.
This PR replaces it with pagy_cursor, a cursor pagination gem based on pagy.