Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue inline formats on enter #3428

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

luin
Copy link
Member

@luin luin commented Aug 16, 2021

It's more intuitive to not preserve inline formats on enter.

It's more intuitive to not preserve inline formats on enter.
@luin luin requested a review from jhchen August 16, 2021 06:29
@jhchen jhchen merged commit 240d02e into develop Aug 18, 2021
@jhchen jhchen deleted the zh-discontinue-inline-formats branch August 18, 2021 22:54
@benbro
Copy link
Contributor

benbro commented Aug 19, 2021

Other editors like Word online, Google Docs and Gmail, preserve inline formats on enter and I can't think of editors that don't.
For example, try typing in Bold in the Gmail email editor and press enter.
Is there a chance to at least make it configurable?

@rishavag1995
Copy link

rishavag1995 commented Apr 19, 2022

@jhchen I agree with @benbro . Not preserving inline formats on enter is rather counter-intuitive. Another side-effect of removing this piece of code is that - if we select a range and then press enter - the inline formats of range.end is now getting auto-applied.

@dumitrascuSorin
Copy link

@luin have you checked the list of open issues recently?
Don't know how you came to the conclusion that 'It's more intuitive to not preserve inline formats on enter.', but a lot of people are considering the contrary.
This should have been marked as a breaking change.

@homestylew
Copy link

why new code

@luin have you checked the list of open issues recently? Don't know how you came to the conclusion that 'It's more intuitive to not preserve inline formats on enter.', but a lot of people are considering the contrary. This should have been marked as a breaking change.

Why is the new code formatting missing

Copy link

@xteextee xteextee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's NOT more intuitive to not preserve inline formats on enter. Please make this behavior at least customizable.

@yarv-dev
Copy link

yarv-dev commented Jan 4, 2025

This kind of tone def response / or lack of response makes it worth moving to lexical or something else..
All advanced text editors preserve text settings, or offer the option to..
just need to add a boolean for this in the config...

    Object.keys(context.format).forEach(name => {
      if (lineFormats[name] != null) return;
      if (Array.isArray(context.format[name])) return;
      if (name === 'code' || name === 'link') return;
      this.quill.format(name, context.format[name], Quill.sources.USER);
    });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants