Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder absent when pad is emptied #1594

Closed
Natim opened this issue Jul 19, 2017 · 8 comments
Closed

Placeholder absent when pad is emptied #1594

Natim opened this issue Jul 19, 2017 · 8 comments

Comments

@Natim
Copy link

Natim commented Jul 19, 2017

Steps for Reproduction

  1. Visit https://quilljs.com/playground/
  2. The placeholder is present
  3. Type something and delete it

Expected behavior:

The placeholder comes back

Actual behavior:

The placeholder doesn't show.

Platforms:

Firefox

Version:

1.3.0

However it does work with Quill 1.2.6

@Natim Natim changed the title No more placeholder on empty pad. No more placeholder on empty-ed pad. Jul 19, 2017
@Natim Natim changed the title No more placeholder on empty-ed pad. No more placeholder on emptied pad. Jul 19, 2017
@Natim Natim changed the title No more placeholder on emptied pad. Placeholder absent when pad is emptied Jul 19, 2017
@jhchen jhchen closed this as completed in eb7f33b Jul 27, 2017
@eamodio
Copy link

eamodio commented Aug 2, 2017

@jhchen will there be a 1.3.1 (or something) release with this fix coming very soon? Would love to not maintain a fork if so (this is a blocker for us)

@jhchen
Copy link
Member

jhchen commented Aug 2, 2017

Yes trying to get a few other bugs in but will release this weekend.

@Natim
Copy link
Author

Natim commented Aug 2, 2017

@eamodio do you have a fix for that in your fork already?

@eamodio
Copy link

eamodio commented Aug 2, 2017

@Natim I haven't forked it (since the next release is nice and close), but the above commit should have fixed it

@Natim
Copy link
Author

Natim commented Aug 2, 2017

Oh neat I missed it :) thanks eb7f33b

jhchen added a commit that referenced this issue Aug 7, 2017
@StreetStrider
Copy link

StreetStrider commented May 25, 2018

Can anyone confirm that this works on 1.3.6? I setup placeholder but it doesn't show up when editor is empty. I'm using minimal (core) css scheme.

@mrowles
Copy link

mrowles commented Jan 31, 2019

Still doesn't work, using ^1.3.6 here

@GJMAC
Copy link

GJMAC commented Mar 15, 2019

Is there going to be a fix applied to this? I just tried to assign a placeholder, but still nothing shows when editor is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants