Add UITapGestureRecognizer on the SWActionSheet to allow dismissal #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taps. This also permits dismissing the action sheet when clicking on the background. The check for which view has been clicked is pretty rudimentary, so I would be interested if someone can come up with something better. Closes skywinder#80
|
What do you mean, as "better"? Is there something bad in this implementation? |
|
Nothing bad, just was hoping for a smarter way to check for the view on which the tap happens. |
|
I tested it on iPhone 5 iOS 7.0.1 |
|
It seems to work fine on iOS 8 though. I have tried debugging today, with no avail. Any ideas? |
|
It also reproduced in simulator. Run example project on iphone 5 + iOS 7.1 and try to click on buttons |
|
@anas-ambri did you find this bug? |
|
It seems the submitter lost interest. Please reference this if you have created a patch. |
Closed
|
@anas-ambri this feature implemented in #140 and will be merged soon! |
|
Thanks @skywinder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UITapGestureRecognizer on the SWActionSheet to allow tracking of taps. This also permits dismissing the action sheet when clicking on the background. The check for which view has been clicked is pretty rudimentary, so I would be interested if someone can come up with something better. Closes #80