Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: update macOS runner to macos-14-large in GitHub Actions #2254

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 6, 2024

Important

Update GitHub Actions runner to macos-14-large in pr-macos.yml for improved build resources.

  • GitHub Actions Workflow:
    • Update runner in .github/workflows/pr-macos.yml from macos-14 to macos-14-large for the build job.

This description was created by Ellipsis for 77440e6. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . ci: update macOS runner to macos-14-large in GitHub Actions Dec 6, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 77440e6 in 7 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/pr-macos.yml:23
  • Draft comment:
    Ensure that the change to 'macos-14-large' is necessary for resource requirements, as it may increase costs. Consider documenting the reason for this change in the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from 'macos-14' to 'macos-14-large' is likely intended to provide more resources for the build process. This is a valid change if the build requires more resources, but it should be justified in the PR description.

Workflow ID: wflow_DQTcFbeU2RpYu58w


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title ci: update macOS runner to macos-14-large in GitHub Actions internal: update macOS runner to macos-14-large in GitHub Actions Dec 6, 2024
@Pospelove Pospelove merged commit 15ef8c9 into main Dec 6, 2024
15 of 16 checks passed
@Pospelove Pospelove deleted the Pospelove-patch-4 branch December 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant