internal: update node-embedder-api-prebuilt vcpkg port #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c865fd3 in 29 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_SeNdRDs4B4jfLdXN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| set(NODE_EMBEDDER_API_FILENAME "node-embedder-api-prebuilt.zip") | ||
| set(NODE_EMBEDDER_API_SHA512 0082a1537052d2343a867cac2eb9acb9ba2da1607c3766ef5ada6fd2498e0fc3df754cabf3a47825358e441a7f594addcf8fdf3be84b05f27fa6eb8aefa1e2ed) | ||
| set(NODE_EMBEDDER_API_SHA512 0) |
There was a problem hiding this comment.
Setting NODE_EMBEDDER_API_SHA512 to 0 disables checksum verification, which is a security risk. Please provide the correct SHA512 checksum for the file.
Pospelove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
portfile.cmaketo change the download URL and reset the SHA512 hash for the node embedder API prebuilt archive.NODE_EMBEDDER_API_URLtohttps://node-embedder-api-prebuilt-vcpkg-port-v2.b-cdn.net/archive.zipinportfile.cmake.NODE_EMBEDDER_API_SHA512to0inportfile.cmake, indicating a placeholder or reset value.This description was created by
for c865fd3. It will automatically update as commits are pushed.