Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ProfilingService and update webpack target to node #2238

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 2, 2024

Important

Add ProfilingService to index.ts and set target to node in webpack.config.js.

  • Services:
    • Add ProfilingService to index.ts for performance monitoring.
  • Webpack Configuration:
    • Set target to node in webpack.config.js to ensure compatibility with Node.js environment.

This description was created by Ellipsis for 199ba8d. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . feat: add ProfilingService and update webpack target to node Dec 2, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 199ba8d in 26 seconds

More details
  • Looked at 35 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-client/webpack.config.js:64
  • Draft comment:
    The target: "node" setting is unnecessary for a client-side application. Consider removing it unless there's a specific reason for its inclusion.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is directly related to the change made in the diff, which is the addition of 'target: "node"'. The comment suggests that this setting might be unnecessary for a client-side application, which is a valid point if the application is indeed client-side. However, without additional context on whether this application is client-side or server-side, it's difficult to definitively say if the comment is correct. The comment is not speculative; it suggests a potential code change if the application is client-side.
    I might be missing the context of whether this application is client-side or server-side, which is crucial to determine the validity of the comment. The comment assumes the application is client-side without evidence.
    The comment is based on a common understanding that 'target: "node"' is typically used for server-side applications. If the application is client-side, the comment is valid. However, without explicit evidence, it's speculative.
    The comment is related to the change and raises a valid point about the 'target: "node"' setting. However, without clear evidence of the application's nature, the comment remains speculative. It should be deleted unless more context is provided.

Workflow ID: wflow_seol6Ho3UMSc6be1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove merged commit 8072e19 into skyrim-multiplayer:main Dec 2, 2024
10 checks passed
@Pospelove Pospelove deleted the profiling branch December 2, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant