fix(skymp5-server): fix missing 'numChanges' in equipmentDump JSON #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
Pospelove
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 78290eb in 32 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_oCrXFIS3OGBmvpMv
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -192,6 +193,15 @@ MpChangeForm MpChangeForm::JsonToChangeForm(simdjson::dom::element& element) | |||
| res.equipmentDump = simdjson::minify(jTmp); | |||
| if (res.equipmentDump == "null") { | |||
| res.equipmentDump.clear(); | |||
| } else { | |||
| auto equipment = nlohmann::json::parse(res.equipmentDump); | |||
There was a problem hiding this comment.
Consider adding exception handling around nlohmann::json::parse to handle potential parsing errors gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add logging for missing 'numChanges' key in
equipmentDumpJSON inMpChangeForm::JsonToChangeForm.MpChangeForm::JsonToChangeForm, ifequipmentDumpJSON lacksnumChanges, it is set to 0 and logged usingspdlog.spdloginclude toMpChangeForms.cppfor logging purposes.This description was created by
for 78290eb. It will automatically update as commits are pushed.