feat(skymp5-server): add OnFireBlocked to ReadBookEvent for blocked book reading handling #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
Pospelove
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2a338e0 in 41 seconds
More details
- Looked at
53lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_2iDcaWy73OmfQL3Q
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
skymp5-server/cpp/server_guest_lib/gamemode_events/ReadBookEvent.cpp
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| auto aSpell = VarValue( | ||
| std::make_shared<EspmGameObject>(br.LookupById(spellOrSkillFormId))); |
There was a problem hiding this comment.
The variable br is used but not declared or initialized. Ensure br is properly defined and initialized before use.
…nt.cpp Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds
OnFireBlockedmethod toReadBookEventto handle blocked book reading events by removing spells.OnFireBlocked(WorldState* worldState)toReadBookEventinReadBookEvent.cppandReadBookEvent.h.OnFireBlockedchecks if the book teaches a spell and removes the spell from the actor if true.script_objects/EspmGameObject.hinReadBookEvent.cpp.This description was created by
for 2a338e0. It will automatically update as commits are pushed.