Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(skymp5-server): replace stringstream with standard C I/O functions #1672

Merged
merged 8 commits into from
Sep 11, 2023

Conversation

barkinlove
Copy link
Collaborator

@barkinlove barkinlove commented Aug 24, 2023


@barkinlove barkinlove self-assigned this Aug 24, 2023
Copy link
Contributor

@Pospelove Pospelove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it doesn't completely reflect our existing functionality (CI is red)

Please fix that and also fix safety issues

skymp5-server/cpp/server_guest_lib/FormDesc.cpp Outdated Show resolved Hide resolved
skymp5-server/cpp/server_guest_lib/FormDesc.cpp Outdated Show resolved Hide resolved
skymp5-server/cpp/server_guest_lib/FormDesc.cpp Outdated Show resolved Hide resolved
skymp5-server/cpp/server_guest_lib/FormDesc.cpp Outdated Show resolved Hide resolved
skymp5-server/cpp/server_guest_lib/FormDesc.cpp Outdated Show resolved Hide resolved
@Pospelove Pospelove self-requested a review August 28, 2023 22:35
@Pospelove Pospelove self-requested a review September 11, 2023 21:58
@Pospelove Pospelove merged commit b33abd2 into skyrim-multiplayer:main Sep 11, 2023
8 checks passed
@Pospelove
Copy link
Contributor

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants