Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Adding filter for default aws vpc if not specified #4546

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

clayrosenthal
Copy link
Contributor

Adding a filter for the default AWS VPC when no VPC is specified. This is matching the docs:

aws:
  # ...
  # VPC to use in each region (optional).
  #
  # If this is set, SkyPilot will only provision in regions that contain a VPC
  # with this name (provisioner automatically looks for such regions).
  # Regions without a VPC with this name will not be used to launch nodes.
  #
  # Default: null (use the default VPC in each region).
  vpc_name: skypilot-vpc

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@clayrosenthal clayrosenthal changed the title Adding filter for default aws vpc if not specified [AWS] Adding filter for default aws vpc if not specified Jan 8, 2025
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clayrosenthal! Pushed some commits to update error messages and docs.

Noting that with this change, SkyPilot will only use either the specified VPC (config.aws.vpc_name), or the default VPC. Other VPCs will not be used unless explicitly specified.

@romilbhardwaj romilbhardwaj enabled auto-merge (squash) January 9, 2025 00:04
@romilbhardwaj romilbhardwaj disabled auto-merge January 9, 2025 00:04
@romilbhardwaj romilbhardwaj merged commit 379711b into skypilot-org:master Jan 9, 2025
18 checks passed
@clayrosenthal clayrosenthal deleted the use-default-vpc branch January 9, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants