-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multithreaded ssh setup #4158
multithreaded ssh setup #4158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @asaiacai! This is a very important improvement. Some quick thoughts : )
bfb95d6
to
2c063dc
Compare
these are some preliminary numbers but need to also test k8s and run smoke tests
after PR
|
reran smoke, but getting pretty limited capacity in AWS which is messing with the smoke tests if I can get some help running smoke on this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making this work @asaiacai!
Runs ssh initialization and setup asynchronously for faster startup. Closes #4156
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py