[k8s] Use SERVICE_ACCOUNT as default remote_identity, add checks for autodown support
#3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… LOCAL_CREDENTIALS
Michaelvll
reviewed
May 8, 2024
There was a problem hiding this comment.
Thanks for fixing this @romilbhardwaj! Mostly look good to me except for the name of the feature. We may want to generalize it a bit instead of limiting it to autodown.
sky/clouds/cloud.py
Outdated
| @@ -43,6 +43,7 @@ class CloudImplementationFeatures(enum.Enum): | |||
| OPEN_PORTS = 'open_ports' | |||
| STORAGE_MOUNTING = 'storage_mounting' | |||
| HOST_CONTROLLERS = 'host_controllers' # Can run jobs/serve controllers | |||
| AUTODOWN = 'autodown' | |||
There was a problem hiding this comment.
How about we just call it AUTOSTOP or AUTO_TEARDOWN as autostop and autodown should have similar requirements for the cloud to support?
There was a problem hiding this comment.
Between these two options, I'll change it to AUTO_TEARDOWN since it would be confusing for a cloud (Kubernetes) to have AUTOSTOP but not STOP feature.
|
Thanks for the comments @Michaelvll!
|
Michaelvll
approved these changes
May 9, 2024
There was a problem hiding this comment.
Thanks @romilbhardwaj! LGTM with a fix for the auto_terminate setting.
Co-authored-by: Zhanghao Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
SERVICE_ACCOUNTdefault remote identity for Kubernetes. This helps with lesser config required for exec based clusters (GKE), and does not cause issues since we anyway need to create an SA for the ssh jump pod.Also adds checks for autodown support, and disable autodown when using exec based auth with
LOCAL_CREDENTIALSon Kubernetes clusters.bash format.shpytest -v tests/test_smoke.py::test_autodownpytest -v tests/test_smoke.py::test_autodown --kubernetessky serve up -n http http_server.yamland verify autodown afterwards