Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][AWS] Allow assumption of AWS Credentials provided in ECS Containers #3503

Merged
merged 3 commits into from
May 8, 2024

Conversation

JGSweets
Copy link
Contributor

@JGSweets JGSweets commented May 2, 2024

Prior to this PR, ECS containers could not launch skypilot jobs because as the type is considered: container-role as opposed to iam-role when evaluating aws configure list.

This PR:

  • Allows ECS container assumed iam credentials to be found by adding the CONTAINER_ROLE value to the AWSIdentityType.
  • adds .env to the .gitignore

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Evaluated sky check w/o the update in an ECS container (failed)
    • Evaluated running sky up ... w/o the update in an ECS container (failed)
    • Evaluated sky check w/ the update in an ECS container (passed)
    • Evaluated running sky up ... w/ the update in an ECS container (passed)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@JGSweets JGSweets marked this pull request as ready for review May 2, 2024 02:26
@JGSweets JGSweets changed the title [CORE][AWS] Allow assumption of AWS Credentials provided in ECS Containers [Core][AWS] Allow assumption of AWS Credentials provided in ECS Containers May 2, 2024
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the support for container_role @JGSweets! This looks great to me.

@Michaelvll Michaelvll merged commit 40a0f57 into skypilot-org:master May 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants