[Core][AWS] Allow assumption of AWS Credentials provided in ECS Containers #3503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, ECS containers could not launch skypilot jobs because as the type is considered:
container-role
as opposed toiam-role
when evaluatingaws configure list
.This PR:
CONTAINER_ROLE
value to theAWSIdentityType
..env
to the .gitignoreTested (run the relevant ones):
bash format.sh
sky check
w/o the update in an ECS container (failed)sky up ...
w/o the update in an ECS container (failed)sky check
w/ the update in an ECS container (passed)sky up ...
w/ the update in an ECS container (passed)pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh